Derk-Jan Hartman [Mon, 23 Jan 2012 18:11:28 +0000 (18:11 +0000)]
Correct mw.Uri.decode to properly decode encoded + signs. Fixes bug 33902
Patch by Fomafix
Sam Reed [Mon, 23 Jan 2012 17:02:51 +0000 (17:02 +0000)]
Redoing r108960 with history
If it was a 3rd party library, there probably wouldn't have been any use doing this
Sam Reed [Mon, 23 Jan 2012 16:59:32 +0000 (16:59 +0000)]
Revert r108987 to copy properly
Alexandre Emsenhuber [Mon, 23 Jan 2012 16:27:13 +0000 (16:27 +0000)]
Cleanup to statistics:
* Removed 'pcache_miss_invalid' from stats.php and clear_stats.php, no longer used
* Added missing 'job-insert' and 'job-pop' to clear_stats.php
* Added missing call to wfIncrStats( 'pcache_miss_absent' ) when there's no key in ParserCacge::get()
* Removed useless 'pcache_not_possible' stat from OutputPage::addWikiTextTitle() since that function is mostly used for interface messages
Jeremy Postlethwaite [Mon, 23 Jan 2012 16:13:20 +0000 (16:13 +0000)]
Adding the jquery cycle plugin. This is being used by the UnitTest extension. See r109762.
Antoine Musso [Mon, 23 Jan 2012 16:08:38 +0000 (16:08 +0000)]
update wgUsersNotifiedOnAllChanges doc (r109826)
Sam Reed [Mon, 23 Jan 2012 15:04:22 +0000 (15:04 +0000)]
Bug 33880 - $wgUsersNotifiedOnAllChanges should not send e-mail to user who made the edit.
Antoine Musso [Mon, 23 Jan 2012 14:50:54 +0000 (14:50 +0000)]
FileRepo: check constructor parameters
new FileRepo() requires an array of parameters having at least the
'name' and 'backend' key setup.
TODO: 'backend' keyword should probably default to FileBackend.
Antoine Musso [Mon, 23 Jan 2012 14:48:49 +0000 (14:48 +0000)]
FileOp: allow creation of an empty file
When creating a file but ommitting the 'content' key, it would throw
a notice. Using getParams let us forget about the 'content' key and
hence create files with no content.
Antoine Musso [Mon, 23 Jan 2012 11:03:45 +0000 (11:03 +0000)]
cleanly handle wikiId on FileBackendBase construction
Use the default array added by r109814
Antoine Musso [Mon, 23 Jan 2012 10:59:02 +0000 (10:59 +0000)]
get a null lock manager by default
Aaron Schulz [Mon, 23 Jan 2012 08:33:31 +0000 (08:33 +0000)]
* Added some wfProfileIn() calls to file backend code.
* Made FileBackend::getFileProps() final.
* Added exception needed in SwiftFileBackend::getConnection().
* Various FileBackendTests fixes and additions. Optimized it a bit by keeping the backend instance in memory.
Aaron Schulz [Mon, 23 Jan 2012 02:55:15 +0000 (02:55 +0000)]
In LockServerDaemon:
* Factored out LockHolder class from main class
* Tweaked a few socket options (using a non-blocking accept() and keep alives for new clients)
Daniel Kinzler [Sun, 22 Jan 2012 20:46:39 +0000 (20:46 +0000)]
reverting r109723 because of slush.
Raimond Spekking [Sun, 22 Jan 2012 20:27:25 +0000 (20:27 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Sun, 22 Jan 2012 17:33:44 +0000 (17:33 +0000)]
Revert feature out of r109562, r109564, r109570
Leaving typo/brace fixes and other minor code improvements
Niklas Laxström [Sun, 22 Jan 2012 12:16:47 +0000 (12:16 +0000)]
Rm extra space
Daniel Kinzler [Sun, 22 Jan 2012 05:58:23 +0000 (05:58 +0000)]
Introducing optional support for <a> tags, to be used with microdata resp. RDFa, as originally suggested in r58694.
This is reintroduced after a discussion with TimStarling considering the discussion about r58717.
Note that a change to the parser will be needed to cause links from <a> tags to be recorded in the externallink table.
gicode [Sun, 22 Jan 2012 04:57:37 +0000 (04:57 +0000)]
Follow-up 102587 to address performance concerns in wfRemoveDotSegments.
Aaron Schulz [Sun, 22 Jan 2012 03:25:19 +0000 (03:25 +0000)]
Simplified last_modified timestamp conversion in SwiftFileBackend to just use wfTimestamp()
Krinkle [Sun, 22 Jan 2012 02:51:06 +0000 (02:51 +0000)]
[Core JS] mediawiki.legacy.protect should be loaded from the top
* The global object created by this legacy module is references from inline on-event attributes as well as from inline <script>'s by ProtectionForm.php
* Needs to be loaded before any of that happens
* Fixes bug 33660
Krinkle [Sun, 22 Jan 2012 02:37:45 +0000 (02:37 +0000)]
[mediawiki.util] minor code cleanup
* Remove distance between variable assignment and usage in mw.util.ini
* Change awkwardly indention from extended var statement into separate flush-left assignments and a simple var statement.
* whitespace etc. (ignore whitespace with -x-uw or on ViewVC diff)
Sam Reed [Sun, 22 Jan 2012 02:01:58 +0000 (02:01 +0000)]
Reverting out r108055 for ease
Sam Reed [Sun, 22 Jan 2012 00:58:47 +0000 (00:58 +0000)]
Add braces
Cache result of variable calls
Minor RELEASE-NOTES-1.19 updates
Aaron Schulz [Sun, 22 Jan 2012 00:34:04 +0000 (00:34 +0000)]
* Modified StoreBatchTest and FileBackendTest to allow specifying a registered backend to use
* Improved FileBackendTest file pruning and added more getFileList() tests
Aaron Schulz [Sun, 22 Jan 2012 00:33:20 +0000 (00:33 +0000)]
* Another fix for SwiftFileBackend file listings
* Fixed bogus array key reference in SwiftFileBackend constructor
Aaron Schulz [Sun, 22 Jan 2012 00:06:18 +0000 (00:06 +0000)]
* Fixed bugs in SwiftFileBackend file listing code
* Clear container cache in SwiftFileBackend when clearCache() is called
* Updated a comment and fixed a comment typo
Krinkle [Sat, 21 Jan 2012 22:26:14 +0000 (22:26 +0000)]
[Unit testing] Add unit tests for Xml::namespaceSelector
* Making Language::namespaceNames explicitly public. It already was but since is being used as such outside the class
Sam Reed [Sat, 21 Jan 2012 21:36:07 +0000 (21:36 +0000)]
* (bug 33865) Exception thrown when using API sandbox action=parse
The actual bug is from wrongly using title when the user wanted page, and hence weren't passing any wikitext...
Raimond Spekking [Sat, 21 Jan 2012 21:12:30 +0000 (21:12 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Krinkle [Sat, 21 Jan 2012 20:13:57 +0000 (20:13 +0000)]
[Action] Fix action=ajax
* Move Ajax stuff to before regular title/page action handling. Ajax actions circumvent most stuff and return early from the regular execution.
* Needed because getAction / Action-classes can't handle action=ajax properly, which isn't until MediaWiki::performAction
* Also undo's debug 'true' in the if-statement from r109688
Krinkle [Sat, 21 Jan 2012 20:10:35 +0000 (20:10 +0000)]
[Wiki.php] Minor clean up
* Comment syntax consistency
* Re-use saved getTitle()
* Doing in separate commit for review ease
Krinkle [Sat, 21 Jan 2012 17:21:53 +0000 (17:21 +0000)]
+@since for getActionName (r109678)
Alexandre Emsenhuber [Sat, 21 Jan 2012 16:45:32 +0000 (16:45 +0000)]
Fix database table name, it is 'profiling', not 'profileinfo'
Platonides [Sat, 21 Jan 2012 16:27:27 +0000 (16:27 +0000)]
Bug 33845: Headings become cursive in TOC when they contain an image
Fixes the problems with r102179 and r102179, as there are
valid tags which begin the same, which meant they were not removed from
the TOC (the second regex, intended to remove tag parameters, then converted
<img or <blockquote> into <i> / <b>).
The same problem existed in the original regex, but as there are no valid
tags which begin with sup or sub, it never happened).
Added comment explaining the tocline regex, and added a bunch of parser tests.
Krinkle [Sat, 21 Jan 2012 13:31:51 +0000 (13:31 +0000)]
[Resources] Add missing or implied dependencies
* mediawiki.action.watch.ajax:
-- Depends on mediawiki.api.watch>mediawiki.api>mediawiki.util
-- But also uses mw.util itself, so adding it here as well. mw.Api might one day not use mw.util
* mediawiki.special.block: Uses mw.util.isIPv4Address / mw.util.isIPv6Address
* mediawiki.special.changeemail: Uses mw.util.validateEmail
* mediawiki.legacy.upload: Uses mw.util.wikiScript
* Uses mw.util.wikiUrlencode
Commit is inspired by and a superset of the patch provided by Rainer@Rillke.eu at bug 33760.
Alexandre Emsenhuber [Sat, 21 Jan 2012 07:59:25 +0000 (07:59 +0000)]
Fix bug 32948:
* {{REVISIONID}} and related variables are no longer blank after doing a null edit
* {{REVISIONID}} and related variables are no longer blank after calling action=purge&forcelinkupdate
Krinkle [Sat, 21 Jan 2012 06:57:34 +0000 (06:57 +0000)]
Reinstate r109223 per CR + fixes
* Action/Context stuff is pretty deeply nested everywhere.
* Should be okay now, at last.
* Reverts reverting r109243
* Same as r109223, except adding this:
+ if ( !$context->canUseWikiPage() ) {
+ return 'view';
+ }
Krinkle [Sat, 21 Jan 2012 06:18:38 +0000 (06:18 +0000)]
[JSTesting] update QUnit html
* Through all QUnit updates, the html was never updated (only the JS/CSS files). Updating html now according to QUnit documentation. (introduced a new html element used for adding test document elements which are automatically cleaned up. the JS/CSS for QUnit was already referring to this but silently failing)
Aaron Schulz [Sat, 21 Jan 2012 00:04:09 +0000 (00:04 +0000)]
* r109659: actually return the exact type we say we do
* Made use of FileRepo::cleanupBatch() in ForeignAPIFile::purgeThumbnails()
Aaron Schulz [Fri, 20 Jan 2012 22:46:35 +0000 (22:46 +0000)]
* Added FileBackend::parentStoragePath() convenience function for getting parent directories.
* In StoreBatchTest: sed proper clean() function to remove temp dirs (follows up r109641). Also removed some commented out code.
* Fixed temp dir leakage in FileBackendTest.
Aaron Schulz [Fri, 20 Jan 2012 21:55:15 +0000 (21:55 +0000)]
Make sure FSFileBackend clears the php stat cache in clearCache(). Otherwise it will just clear the FileBackend cache and refetch the same cached data from PHP's stat cache.
Aaron Schulz [Fri, 20 Jan 2012 20:52:09 +0000 (20:52 +0000)]
Similar to r108937: fixed breakage where the zone urls were defined as relative paths.
Raimond Spekking [Fri, 20 Jan 2012 20:41:42 +0000 (20:41 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Platonides [Fri, 20 Jan 2012 20:15:26 +0000 (20:15 +0000)]
Fix folder leakage.
Platonides [Fri, 20 Jan 2012 19:46:27 +0000 (19:46 +0000)]
If you are going to leak folders, at least give them your surname.
Niklas Laxström [Fri, 20 Jan 2012 19:09:55 +0000 (19:09 +0000)]
Can't PHP just DWIM? Ping r109628
Niklas Laxström [Fri, 20 Jan 2012 16:57:46 +0000 (16:57 +0000)]
Reducy query flood in r96546. Allow formatters to provide titles for LinkBatch.
Alexandre Emsenhuber [Fri, 20 Jan 2012 16:12:34 +0000 (16:12 +0000)]
* Inlinise Preferences::loadOldSearchNs() in SearchEngine::userNamespaces(); the latter is the only caller of the former
* Made code clearer and removed duplication
* Marked Preferences::loadOldSearchNs() as deprecated
Niklas Laxström [Fri, 20 Jan 2012 09:44:39 +0000 (09:44 +0000)]
Split LogPager out of LogEventsList.php
Aaron Schulz [Fri, 20 Jan 2012 00:12:20 +0000 (00:12 +0000)]
Message change I forgot to commit in r109583
Krinkle [Thu, 19 Jan 2012 23:52:46 +0000 (23:52 +0000)]
[mediawiki.js] edit comment
* Follows-up r108230
Aaron Schulz [Thu, 19 Jan 2012 23:18:03 +0000 (23:18 +0000)]
* Follow-up r109009: Check that paths are usable in FileOp::doPrecheck(). Also lock parent directories to avoid prepare()/clean() race conditions for FS backends.
* Fixed bogus $params var in logException() call in SwiftFileBackend.
* Added 'latest' param to FileBackendMultliWrite::consistencyCheck().
* Dummy-proof FileBackend::getFileStat() w.r.t the 'latest' param and removed related FileOp::allowStaleReads() comment.
* Tweaked backend-fail-batchsize message from r109469.
Antoine Musso [Thu, 19 Jan 2012 23:06:23 +0000 (23:06 +0000)]
comment wgLocalFileRepo has an example usage in Setup.php
Raimond Spekking [Thu, 19 Jan 2012 21:38:41 +0000 (21:38 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Thu, 19 Jan 2012 21:12:37 +0000 (21:12 +0000)]
r109562: Register new message key for maintenance script
Sam Reed [Thu, 19 Jan 2012 20:26:10 +0000 (20:26 +0000)]
Followup r109562
Don't use such a naieve host check
Sam Reed [Thu, 19 Jan 2012 19:16:06 +0000 (19:16 +0000)]
* (bug 32341) Add upload by URL domain limitation.
Niklas Laxström [Thu, 19 Jan 2012 19:11:59 +0000 (19:11 +0000)]
Remove extra space, ping r109550
Benny Situ [Thu, 19 Jan 2012 18:22:53 +0000 (18:22 +0000)]
followup to r107187 - Making textarea width to be 100% in all skins
Sam Reed [Thu, 19 Jan 2012 17:27:29 +0000 (17:27 +0000)]
Documentation
Remove unused globals
Antoine Musso [Thu, 19 Jan 2012 17:22:36 +0000 (17:22 +0000)]
design file for nested tables CSS
See:
Bug 33752 - Wikitable uses CSS not supported in IE6
r107669
Sam Reed [Thu, 19 Jan 2012 16:55:42 +0000 (16:55 +0000)]
Add some escaping to r109547, 109548, 109549
Improve RELEASE-NOTES-1.19 also
Sam Reed [Thu, 19 Jan 2012 16:44:49 +0000 (16:44 +0000)]
* (bug 33819) Display filesize on Special:NewFiles in appropriate unit.
Do the same for the rest of the file usages of 'nbytes' in Generic.php
Sam Reed [Thu, 19 Jan 2012 16:41:04 +0000 (16:41 +0000)]
Like r109547, display file size in appropriate units on mimesearch
Sam Reed [Thu, 19 Jan 2012 16:37:54 +0000 (16:37 +0000)]
* (bug 33819) Display filesize on Special:NewFiles in appropriate unit.
Sam Reed [Thu, 19 Jan 2012 16:33:57 +0000 (16:33 +0000)]
Cache gallery object, don't create a new one unless we need to
Make getStartBody return something
Sam Reed [Thu, 19 Jan 2012 15:22:28 +0000 (15:22 +0000)]
Fix stray comma from r109537
Sam Reed [Thu, 19 Jan 2012 14:56:18 +0000 (14:56 +0000)]
Documentation and whitespace
Clearing another w/c
Sam Reed [Thu, 19 Jan 2012 14:17:22 +0000 (14:17 +0000)]
Remove unused globals
Remove pointless continue;
Clearing up w/c
Niklas Laxström [Thu, 19 Jan 2012 11:00:48 +0000 (11:00 +0000)]
Less Title Case
Niklas Laxström [Thu, 19 Jan 2012 11:00:18 +0000 (11:00 +0000)]
12em was too narrow, 18 seems to be better
Niklas Laxström [Thu, 19 Jan 2012 10:58:49 +0000 (10:58 +0000)]
Table headers looked ugly without the same padding as content
Alexandre Emsenhuber [Thu, 19 Jan 2012 10:08:38 +0000 (10:08 +0000)]
Change $wgDebugFunctionEntry's default value from 0 to false; it is supposed to be a boolean, not an integer.
Alexandre Emsenhuber [Thu, 19 Jan 2012 10:05:38 +0000 (10:05 +0000)]
$wgLanguageCode goes with $wgContLang, not $wgLang. This was breaking ApiBlockTest because $wgContLang->getCode() != $wgLanguageCode.
Niklas Laxström [Thu, 19 Jan 2012 09:20:32 +0000 (09:20 +0000)]
Typofix, ping r109446
Aaron Schulz [Thu, 19 Jan 2012 02:26:10 +0000 (02:26 +0000)]
Reverted r109062 per code slush (also has a CR complaint)
Aaron Schulz [Thu, 19 Jan 2012 02:24:49 +0000 (02:24 +0000)]
Renamed 'overwriteDest' FileBackend operation parameter to just 'overwrite', which is shorter and more consistent with 'overwriteSame'
Aaron Schulz [Thu, 19 Jan 2012 02:07:48 +0000 (02:07 +0000)]
In FileBackend/FileOp:
* Added a sane default max file size to FileBackend. Operation batches need to check this before trying anything.
* Temporarily adjust the PHP execution time limit in attemptBatch() to reduce the chance of dying in the middle of it. Also added a maximum batch size limit.
* Added some code comments.
mrbluesky [Thu, 19 Jan 2012 02:04:30 +0000 (02:04 +0000)]
Update comment
mrbluesky [Thu, 19 Jan 2012 01:51:27 +0000 (01:51 +0000)]
Comments on status codes
mrbluesky [Wed, 18 Jan 2012 22:46:26 +0000 (22:46 +0000)]
(bug 32899) Alphabetical sorting for methods and properties in doxygen
mrbluesky [Wed, 18 Jan 2012 22:40:51 +0000 (22:40 +0000)]
Additional doc/comments
Sam Reed [Wed, 18 Jan 2012 21:27:28 +0000 (21:27 +0000)]
Add __METHOD__ to begin/commit
Improve error message from r109433
Sam Reed [Wed, 18 Jan 2012 21:20:50 +0000 (21:20 +0000)]
Just experienced with commons. Dealt with UploadStashBadPathException
path doesn't exist
Backtrace:
#0 /home/wikipedia/common/php-1.18/maintenance/cleanupUploadStash.php(68): UploadStash->getFile('zyvzeiza5hg.xab...', true)
#1 /home/wikipedia/common/php-1.18/maintenance/doMaintenance.php(105): UploadStashCleanup->execute()
#2 /home/wikipedia/common/php-1.18/maintenance/cleanupUploadStash.php(75): require_once('/home/wikipedia...')
#3 /home/wikipedia/common/multiversion/MWScript.php(73): require_once('/home/wikipedia...')
#4 {main}
Raimond Spekking [Wed, 18 Jan 2012 21:07:15 +0000 (21:07 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Wed, 18 Jan 2012 20:01:46 +0000 (20:01 +0000)]
Make time of '-total' item correct if using 'user' time metric
Aaron Schulz [Wed, 18 Jan 2012 19:57:32 +0000 (19:57 +0000)]
In SwiftFileBackend:
* r108944: doCleanInternal() should delete empty containers only if the container dir was given.
* Made doSecureInternal() set container permissions. Also renamed swiftProxyUser -> swiftAnonUser.
* Made doGetFileStat() respect the 'latest' parameter (using r109235).
* Fixed connTTL default and renamed it to authTTL. Also added explicit close() call to getConnection().
* Reduced RTTs in doPrepareInternal() by checking getContainer() first (which is process cached).
* Killed an RTT in doStoreInternal(), doCreateInternal(), and doCopyInternal() by using create_object(). Also cleaned up logic with regards to the destination CF_Object object fields getting preloaded before write().
* Cleanups to getLocalCopy(); only create the tmp file if get_object() succeeds to short-circuits things.
* Made getContainer() limit the container cache size for sanity.
* Simplified doDeleteInternal() code a bit.
* Renamed $destRel => $dstRel for consistency.
Siebrand Mazeland [Wed, 18 Jan 2012 18:20:50 +0000 (18:20 +0000)]
Remove support for the deprecated and no longer used in trunk hook MagicWordMagicWords.
Siebrand Mazeland [Wed, 18 Jan 2012 17:53:04 +0000 (17:53 +0000)]
Update documentation.
Siebrand Mazeland [Wed, 18 Jan 2012 17:43:08 +0000 (17:43 +0000)]
Update documentation as LanguageGetMagic hook is deprecated.
Antoine Musso [Wed, 18 Jan 2012 15:58:25 +0000 (15:58 +0000)]
MWDebugTest: clear log before running tests
Some other test could have added their own logs, for example
deprecated notice. In that case, the first test will fail because
the log array already has some content :-b
Antoine Musso [Wed, 18 Jan 2012 15:50:00 +0000 (15:50 +0000)]
tests: mark tests requiring a database connection
Alexandre Emsenhuber [Wed, 18 Jan 2012 14:48:35 +0000 (14:48 +0000)]
Fix profiling, that function is not profiled
Alexandre Emsenhuber [Wed, 18 Jan 2012 12:10:16 +0000 (12:10 +0000)]
Pass some more __METHOD__ to DatabaseBase::begin() and DatabaseBase::commit()
Antoine Musso [Wed, 18 Jan 2012 10:36:45 +0000 (10:36 +0000)]
dbg toolbar: prevents screen jumping
preventDefault() ask the browser to ignore URL fragment which
we handle manually (by closing/opening tabs).
Works with Hovzer plugin added by r107982
ping r105122
Siebrand Mazeland [Wed, 18 Jan 2012 08:05:27 +0000 (08:05 +0000)]
Follow-up r107881: revert. Adding forgotten part in r109260.
Gabriel Wicke [Wed, 18 Jan 2012 01:38:44 +0000 (01:38 +0000)]
Correct typo in comment, so that it reflects the spec and the actual value in
the regexp.
Siebrand Mazeland [Wed, 18 Jan 2012 00:26:11 +0000 (00:26 +0000)]
Revert r107881 per CR.
Aaron Schulz [Tue, 17 Jan 2012 23:07:15 +0000 (23:07 +0000)]
Reverted r109223 per CR